Re: [PATCH v1 2/9] thermal: thermal: Export OF trip helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Francesco,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on rafael-pm/thermal krzk/for-next krzk-mem-ctrl/for-next v5.19-rc2 next-20220615]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Francesco-Dolcini/imx-thermal-Allow-trip-point-configuration-from-DT/20220615-175857
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20220616/202206160331.en1dbvYm-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/e68c5a0d2b91a47a9df63a6309c0ed9e905fc20a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Francesco-Dolcini/imx-thermal-Allow-trip-point-configuration-from-DT/20220615-175857
        git checkout e68c5a0d2b91a47a9df63a6309c0ed9e905fc20a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from drivers/thermal/thermal_core.c:27:
   drivers/thermal/thermal_core.h: In function 'thermal_of_populate_trip':
>> drivers/thermal/thermal_core.h:179:17: error: 'ENOTSUP' undeclared (first use in this function); did you mean 'ENOTSUPP'?
     179 |         return -ENOTSUP;
         |                 ^~~~~~~
         |                 ENOTSUPP
   drivers/thermal/thermal_core.h:179:17: note: each undeclared identifier is reported only once for each function it appears in


vim +179 drivers/thermal/thermal_core.h

   150	
   151	/* device tree support */
   152	#ifdef CONFIG_THERMAL_OF
   153	int of_parse_thermal_zones(void);
   154	int of_thermal_get_ntrips(struct thermal_zone_device *);
   155	bool of_thermal_is_trip_valid(struct thermal_zone_device *, int);
   156	const struct thermal_trip *
   157	of_thermal_get_trip_points(struct thermal_zone_device *);
   158	int thermal_of_populate_trip(struct device_node *np,
   159				     struct thermal_trip *trip);
   160	#else
   161	static inline int of_parse_thermal_zones(void) { return 0; }
   162	static inline int of_thermal_get_ntrips(struct thermal_zone_device *tz)
   163	{
   164		return 0;
   165	}
   166	static inline bool of_thermal_is_trip_valid(struct thermal_zone_device *tz,
   167						    int trip)
   168	{
   169		return false;
   170	}
   171	static inline const struct thermal_trip *
   172	of_thermal_get_trip_points(struct thermal_zone_device *tz)
   173	{
   174		return NULL;
   175	}
   176	static inline int thermal_of_populate_trip(struct device_node *np,
   177						   struct thermal_trip *trip)
   178	{
 > 179		return -ENOTSUP;
   180	}
   181	#endif
   182	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux