Re: [PATCH v6 2/2] usb: gadget: pxa27x_udc: add devicetree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Sep 24, 2014 at 9:41 PM, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote:

> Add support for device-tree device discovery. If devicetree is not
> provided, fallback to legacy platform data "discovery".
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
(...)
> @@ -2417,6 +2425,8 @@ static int pxa_udc_probe(struct platform_device *pdev)
>         if (mach) {
>                 udc->gpiod = gpio_to_desc(mach->gpio_pullup);
>                 udc->udc_command = mach->udc_command;
> +       } else {
> +               udc->gpiod = devm_gpiod_get(&pdev->dev, NULL);
>         }

Aha OK there it is.

devm_gpiod_get() actually uses three arguments now, you're using
a deprecated version of the interface:

struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                              const char *con_id,
                                              enum gpiod_flags flags);

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux