On 14/06/2022 12:34, Prashant Malani wrote: > Analogix 7625 can be used in systems to switch USB Type-C DisplayPort > alternate mode lane traffic between 2 Type-C ports. > > Update the binding to accommodate this usage by introducing a switch > property. > > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> > Tested-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> > Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx> > --- > > Changes since v2: > - Added Reviewed-by and Tested-by tags. > > Changes since v1: > - Introduced patternProperties for "switch" children (suggested by Krzysztof Kozlowski). > - Added unevaluatedProperties descriptor (suggested by Krzysztof Kozlowski). > - Added "address-cells" and "size-cells" properties to "switches". > > .../display/bridge/analogix,anx7625.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 35a48515836e..cb4a23391244 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -105,6 +105,33 @@ properties: > - port@0 > - port@1 > > + switches: > + type: object > + description: Set of switches controlling DisplayPort traffic on > + outgoing RX/TX lanes to Type C ports. > + unevaluatedProperties: false This should be additionalProperties:false. > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + patternProperties: > + 'switch@[01]': You also need ^ and $. Please use the same quotes as in other places (here is ' but few lines above ") > + $ref: /schemas/usb/typec-switch.yaml# You need unevaluatedProperties:false on this level. > + > + properties: > + reg: > + maxItems: 1 > + > + required: > + - reg > + > + required: > + - switch@0 > + Best regards, Krzysztof
