Re: [PATCH 2/2] media: i2c: imx412: Add imx577 compatible string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/06/2022 05:00, Sakari Ailus wrote:
Thanks for the patch.

Surely the sensors still have some differences.

They do, they absolutely do, the imx577 has a whole bunch of extra modes.

We don't have any reference code or access to documentation for those modes.

My reference is the qualcomm camx code for the rb5 board, which includes a imx577 sensor. That stack uses the same init code as for the 412.

So for that baseline mode, the imx412 driver works perfectly.

Even if the same registers would work as-is (the imx577 might still benefit
from different MSRs?), the user should know which sensor it is. I.e. please
set the media entity name accordingly. See e.g. the CCS driver for an
example.

Agreed, I'll do that.

---
bod



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux