Hi Ansuel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mtd/nand/next] [also build test WARNING on mtd/mtd/next mtd/mtd/fixes robh/for-next v5.19-rc2 next-20220610] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Ansuel-Smith/Add-support-for-unprotected-spare-data-page/20220608-104834 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next config: hexagon-randconfig-r041-20220613 (https://download.01.org/0day-ci/archive/20220613/202206132205.G3tGFPx7-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d378268ead93c85803c270277f0243737b536ae7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/5f9263b88e99a6cae44be5e737cb0928ee420e87 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Ansuel-Smith/Add-support-for-unprotected-spare-data-page/20220608-104834 git checkout 5f9263b88e99a6cae44be5e737cb0928ee420e87 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/nand/raw/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/mtd/nand/raw/qcom_nandc.c:3020:10: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] return ret; ^~~ drivers/mtd/nand/raw/qcom_nandc.c:3009:33: note: initialize the variable 'ret' to silence this warning int partitions_count, i, j, ret; ^ = 0 1 warning generated. vim +/ret +3020 drivers/mtd/nand/raw/qcom_nandc.c 3000 3001 static int qcom_nand_host_parse_boot_partitions(struct qcom_nand_controller *nandc, 3002 struct qcom_nand_host *host, 3003 struct device_node *dn) 3004 { 3005 struct nand_chip *chip = &host->chip; 3006 struct mtd_info *mtd = nand_to_mtd(chip); 3007 struct qcom_nand_boot_partition *boot_partition; 3008 struct device *dev = nandc->dev; 3009 int partitions_count, i, j, ret; 3010 3011 if (!nandc->props->use_codeword_fixup) 3012 return 0; 3013 3014 if (!of_find_property(dn, "qcom,boot-partitions", NULL)) 3015 return 0; 3016 3017 partitions_count = of_property_count_u32_elems(dn, "qcom,boot-partitions"); 3018 if (partitions_count < 0) { 3019 dev_err(dev, "Error parsing boot partition."); > 3020 return ret; 3021 } 3022 3023 host->nr_boot_partitions = partitions_count / 2; 3024 host->boot_partitions = devm_kcalloc(dev, host->nr_boot_partitions, 3025 sizeof(*host->boot_partitions), GFP_KERNEL); 3026 if (!host->boot_partitions) 3027 return -ENOMEM; 3028 3029 for (i = 0, j = 0; i < host->nr_boot_partitions; i++, j += 2) { 3030 boot_partition = &host->boot_partitions[i]; 3031 3032 ret = of_property_read_u32_index(dn, "qcom,boot-partitions", j, 3033 &boot_partition->page_offset); 3034 if (ret) { 3035 dev_err(dev, "Error parsing boot partition offset at index %d", i); 3036 return ret; 3037 } 3038 3039 if (boot_partition->page_offset % mtd->writesize) { 3040 dev_err(dev, "Boot partition offset not multiple of writesize at index %i", 3041 i); 3042 return -EINVAL; 3043 } 3044 /* Convert offset to nand pages */ 3045 boot_partition->page_offset /= mtd->writesize; 3046 3047 ret = of_property_read_u32_index(dn, "qcom,boot-partitions", j + 1, 3048 &boot_partition->page_size); 3049 if (ret) { 3050 dev_err(dev, "Error parsing boot partition size at index %d", i); 3051 return ret; 3052 } 3053 3054 if (boot_partition->page_size % mtd->writesize) { 3055 dev_err(dev, "Boot partition size not multiple of writesize at index %i", 3056 i); 3057 return -EINVAL; 3058 } 3059 /* Convert size to nand pages */ 3060 boot_partition->page_size /= mtd->writesize; 3061 } 3062 3063 return 0; 3064 } 3065 -- 0-DAY CI Kernel Test Service https://01.org/lkp
