On 12/06/2022 17:05, Nicolas Frattaroli wrote: >>> + >>> + clock-names: >>> + items: >>> + - const: aclk >>> + - const: hclk >> >> Since these are new bindings, it would be good to follow DT convention >> and not add common "clk" prefix to clocks. Just like DMA is "tx" not >> "txdma". However clock names "a" and "h" are also not good and maybe >> this is already shared implementation? > > This is indeed a shared implementation. Theoretically I could change > the driver for this one case but that seems pointless, especially > since "aclk" and "hclk" are the usual clk names for AXI and AHB on > ARM as far as I understand. I think I've been told before that those > two clocks should always be called aclk and hclk. > ok Best regards, Krzysztof