On Fri, Jun 10, 2022 at 09:34:46AM -0700, Randy Dunlap wrote: > Hi-- Hi Randy > > On 6/10/22 01:17, Serge Semin wrote: > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > > index bb45a9c00514..95e0e022b5bb 100644 > > --- a/drivers/ata/Kconfig > > +++ b/drivers/ata/Kconfig > > @@ -176,6 +176,16 @@ config AHCI_DM816 > > > > If unsure, say N. > > > > +config AHCI_DWC > > + tristate "Synopsys DWC AHCI SATA support" > > + select SATA_HOST > > + default SATA_AHCI_PLATFORM > > I don't think this needs to default to SATA_AHCI_PLATFORM. > It might build a driver that isn't needed. > And it's incompatible with "If unsure, say N." Basically you are right, but this particular setting is connected with the modification I've done in the drivers/ata/ahci_platform.c driver in the framework of this commit. I've moved the "snps,spear-ahci" and "snps,dwc-ahci" compatible devices support to the new driver. Thus should I omit the SATA_AHCI_PLATFORM dependency their default kernel configs will lack the corresponding controllers support. If it's not a problem and we can rely on the kernel build system ability to ask whether the new config needs to be set/cleared, then I would be very happy to drop the default setting. What do you think? -Sergey > > > + help > > + This option enables support for the Synopsys DWC AHCI SATA > > + controller implementation. > > + > > + If unsure, say N. > > -- > ~Randy
