On Wed, Jun 08, 2022 at 02:19:02PM -0500, Bjorn Helgaas wrote:
> On Wed, Jun 08, 2022 at 08:51:47AM -0600, Rob Herring wrote:
> > On Wed, Jun 08, 2022 at 07:45:07AM -0600, Rob Herring wrote:
> > > On Wed, 08 Jun 2022 13:22:06 +0300, Dmitry Baryshkov wrote:
> > > > On Qualcomm platforms each group of 32 MSI vectors is routed to the
> > > > separate GIC interrupt. Document mapping of additional interrupts.
> > > >
> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > > > ---
> > > > .../devicetree/bindings/pci/qcom,pcie.yaml | 53 +++++++++++++++++--
> > > > 1 file changed, 50 insertions(+), 3 deletions(-)
> > > >
> > >
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/qcom,pcie.yaml: allOf:19:then:oneOf:0:properties:interrupt-names: {'maxItems': 1, 'items': [{'const': 'msi'}]} should not be valid under {'required': ['maxItems']}
> > > hint: "maxItems" is not needed with an "items" list
> > > from schema $id: http://devicetree.org/meta-schemas/items.yaml#
> > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/qcom,pcie.yaml: allOf:19:then:oneOf:1:properties:interrupt-names: 'oneOf' conditional failed, one must be fixed:
> > > [{'const': 'msi0'}, {'const': 'msi1'}, {'const': 'msi2'}, {'const': 'msi3'}, {'const': 'msi4'}, {'const': 'msi5'}, {'const': 'msi6'}, {'const': 'msi7'}] is too long
> > > [{'const': 'msi0'}, {'const': 'msi1'}, {'const': 'msi2'}, {'const': 'msi3'}, {'const': 'msi4'}, {'const': 'msi5'}, {'const': 'msi6'}, {'const': 'msi7'}] is too short
> > > False schema does not allow 8
> > > 1 was expected
> > > 8 is greater than the maximum of 2
> > > 8 is greater than the maximum of 3
> > > 8 is greater than the maximum of 4
> > > 8 is greater than the maximum of 5
> > > 8 is greater than the maximum of 6
> > > 8 is greater than the maximum of 7
> > > hint: "minItems" is only needed if less than the "items" list length
> > > from schema $id: http://devicetree.org/meta-schemas/items.yaml#
> > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/qcom,pcie.yaml: ignoring, error in schema: allOf: 19: then: oneOf: 0: properties: interrupt-names
> > > Documentation/devicetree/bindings/pci/qcom,pcie.example.dtb:0:0: /example-0/pcie@1b500000: failed to match any schema with compatible: ['qcom,pcie-ipq8064']
> > > Documentation/devicetree/bindings/pci/qcom,pcie.example.dtb:0:0: /example-1/pcie@fc520000: failed to match any schema with compatible: ['qcom,pcie-apq8084']
> >
> > These are due to a new check in dtschema main branch not yet released.
>
> Even though these are new checks, I guess we should fix them before
> merging this series? If not, let me know.
Yes, or it is more wack-a-mole for me.
Rob
