Re: [PATCH] of: fdt: fix memory range check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






On 24/09/14 15:38, Grant Likely wrote:
--- a/drivers/of/fdt.c
>+++ b/drivers/of/fdt.c
>@@ -937,7 +937,7 @@ void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
>  		return;
>  	}
>
>-	if (base + size > MAX_PHYS_ADDR) {
>+	if (base + size - 1 > MAX_PHYS_ADDR) {
>  		pr_warning("Ignoring memory range 0x%lx - 0x%llx\n",
>  				ULONG_MAX, base + size);
>  		size = MAX_PHYS_ADDR - base;
By that logic, the above two lines need to be repaired also:
Thanks for fixing this too.

		pr_warning("Ignoring memory range 0x%lx - 0x%llx\n",
				MAX_PHYS_ADDR + 1, base + size);

I think the first argument should be printed in 0x%llx format as there would be a 32bit overflow for MAX_PHYS_ADDR + 1.

		size = MAX_PHYS_ADDR - base + 1;

I've fixed it up and applied, thanks.

--srini
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux