Hello Rob, On 09/06/22 23:56, Rob Herring wrote: > On Mon, Jun 06, 2022 at 04:34:41PM +0530, Siddharth Vadapalli wrote: >> Update bindings for TI K3 J7200 SoC which contains 5 ports (4 external >> ports) CPSW5G module and add compatible for it. >> >> Changes made: >> - Add new compatible ti,j7200-cpswxg-nuss for CPSW5G. >> - Extend pattern properties for new compatible. >> - Change maximum number of CPSW ports to 4 for new compatible. >> >> Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx> >> --- >> .../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 135 ++++++++++++------ >> 1 file changed, 93 insertions(+), 42 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml >> index b8281d8be940..49f63aaf5a08 100644 >> --- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml >> +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml >> @@ -57,6 +57,7 @@ properties: >> - ti,am654-cpsw-nuss >> - ti,j721e-cpsw-nuss >> - ti,am642-cpsw-nuss >> + - ti,j7200-cpswxg-nuss >> >> reg: >> maxItems: 1 >> @@ -108,48 +109,98 @@ properties: >> const: 1 >> '#size-cells': >> const: 0 >> - >> - patternProperties: >> - port@[1-2]: > > Just change this to 'port@[1-4]'. > >> - type: object >> - description: CPSWxG NUSS external ports >> - >> - $ref: ethernet-controller.yaml# >> - >> - properties: >> - reg: >> - minimum: 1 >> - maximum: 2 > > And this to 4. > > Then, you just need this to disallow the additional ports: > > if: > not: > properties: > compatible: > contains: > const: ti,j7200-cpswxg-nuss > then: > patternProperties: > '^port@[3-4]$': false Thank you for the suggestion. I will implement this and send the v4 series. Regards, Siddharth.
