On Tue, Sep 23, 2014 at 5:39 AM, Hongzhou.Yang <srv_hongzhou.yang@xxxxxxxxxxxx> wrote: > From: Hongzhou Yang <hongzhou.yang@xxxxxxxxxxxx> > > Add pinctrl node to mt8135.dtsi. > > Signed-off-by: Hongzhou Yang <hongzhou.yang@xxxxxxxxxxxx> (...) > +#define MT8135_PIN_0_MSDC0_DAT7__FUNC_GPIO0 (MT_PIN_NO(0) | 0) > +#define MT8135_PIN_0_MSDC0_DAT7__FUNC_MSDC0_DAT7 (MT_PIN_NO(0) | 1) > +#define MT8135_PIN_0_MSDC0_DAT7__FUNC_EINT49 (MT_PIN_NO(0) | 2) > +#define MT8135_PIN_0_MSDC0_DAT7__FUNC_I2SOUT_DAT (MT_PIN_NO(0) | 3) I haven't got to reviewing the driver, but this looks just wrong. Have the magic numbers in the driver. Use strings to describe functions, not integers. We need to move toward standardized device tree bindings for this stuff, and that means using strings, not magic numbers. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
