On 08/06/2022 11:31, Kavyasree.Kotagiri@xxxxxxxxxxxxx wrote: >>> Convert the Atmel flexcom device tree bindings to json schema. >>> >>> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx> >>> --- >>> v1 -> v2: >>> - Fix title. >>> >>> .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ >>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ >>> 2 files changed, 97 insertions(+), 63 deletions(-) >>> create mode 100644 >> Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- >> flexcom.txt >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >> b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>> new file mode 100644 >>> index 000000000000..05cb6ebb4b2a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>> @@ -0,0 +1,97 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Atmel Flexcom (Flexible Serial Communication Unit) >>> + >>> +maintainers: >>> + - Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx> >>> + >>> +description: >>> + The Atmel Flexcom is just a wrapper which embeds a SPI controller, >>> + an I2C controller and an USART. Only one function can be used at a >>> + time and is chosen at boot time according to the device tree. >>> + >>> +properties: >>> + compatible: >>> + const: atmel,sama5d2-flexcom >> >> Same comment applies as before... Your previous set was better here and >> for some reason you decided to change it. This should be enum so you >> avoid useless change next patch. >> > Thanks for your comments. > Do you mean use "enum" instead of "const" in current patch itself and add new compatible in 2/3 patch? Yes. This is how you did it in previous patchsets. Best regards, Krzysztof
