On 04/06/2022 00:20, Linus Walleij wrote: > On Thu, May 26, 2022 at 4:37 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> For convenience (less code duplication, some meaning added to raw >> number), the pin controller pin configuration register values >> were defined in the bindings header. These are not some IDs or other >> abstraction layer but raw numbers used in the registers >> >> These constants do not fit the purpose of bindings. They do not provide >> any abstraction, any hardware and driver independent ID. With minor >> exceptions, the Linux drivers actually do not use the bindings header at >> all. >> >> All of the constants were moved already to headers local to DTS >> (residing in DTS directory), so remove any references to the bindings >> header and add a warning tha tit is deprecated. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > This looks like something that needs to be merged on top of the > other patches so if you wanna merge this through ARM SoC: > Reviewed-by: Linus Walleij <linus.wallej@xxxxxxxxxx> > > Else just tell me a merging strategy and I'll use it! Thanks, actually I should split the bindings from driver changes and then the driver part could be applied independently. I'll send a v3 and then I can actually handle cross-tree dependencies between both of my Samsung tree - SoC and pinctrl. Best regards, Krzysztof
