On Fri, 29 Apr 2022 15:01:36 -0700 Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote: > Field for PROX_CTRL4 should contain PROX_CTRL4. > > Fixes: 4c18a890dff8d ("iio:proximity:sx9324: Add SX9324 support") > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx> > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> Applied > --- > No Changes in v5. > Changes since v3: > - Added Review tags. > > Changes since v2: > - no changes > > Changes since v1: > - Add Fixes keyword in commit message. > > drivers/iio/proximity/sx9324.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c > index 378c2a17bae6e..a7d9a53692a6d 100644 > --- a/drivers/iio/proximity/sx9324.c > +++ b/drivers/iio/proximity/sx9324.c > @@ -90,7 +90,7 @@ > #define SX9324_REG_PROX_CTRL4_AVGNEGFILT_MASK GENMASK(5, 3) > #define SX9324_REG_PROX_CTRL4_AVGNEG_FILT_2 0x08 > #define SX9324_REG_PROX_CTRL4_AVGPOSFILT_MASK GENMASK(2, 0) > -#define SX9324_REG_PROX_CTRL3_AVGPOS_FILT_256 0x04 > +#define SX9324_REG_PROX_CTRL4_AVGPOS_FILT_256 0x04 > #define SX9324_REG_PROX_CTRL5 0x35 > #define SX9324_REG_PROX_CTRL5_HYST_MASK GENMASK(5, 4) > #define SX9324_REG_PROX_CTRL5_CLOSE_DEBOUNCE_MASK GENMASK(3, 2) > @@ -794,7 +794,7 @@ static const struct sx_common_reg_default sx9324_default_regs[] = { > { SX9324_REG_PROX_CTRL3, SX9324_REG_PROX_CTRL3_AVGDEB_2SAMPLES | > SX9324_REG_PROX_CTRL3_AVGPOS_THRESH_16K }, > { SX9324_REG_PROX_CTRL4, SX9324_REG_PROX_CTRL4_AVGNEG_FILT_2 | > - SX9324_REG_PROX_CTRL3_AVGPOS_FILT_256 }, > + SX9324_REG_PROX_CTRL4_AVGPOS_FILT_256 }, > { SX9324_REG_PROX_CTRL5, 0x00 }, > { SX9324_REG_PROX_CTRL6, SX9324_REG_PROX_CTRL6_PROXTHRESH_32 }, > { SX9324_REG_PROX_CTRL7, SX9324_REG_PROX_CTRL6_PROXTHRESH_32 },