RE: [PATCH V5 6/6] dt-bindings: iio: accel: Add bmi085 and bmi090l bindings

[LI Qingwu <qing-wu.li@xxxxxxxxxxxxxxxxxxxxxxx>]

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Thursday, June 2, 2022 9:58 PM
> To: LI Qingwu <Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx>
> Cc: jic23@xxxxxxxxxx; lars@xxxxxxxxxx; mchehab+huawei@xxxxxxxxxx;
> ardeleanalex@xxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; mike.looijmans@xxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; HAEMMERLE Thomas
> <thomas.haemmerle@xxxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH V5 6/6] dt-bindings: iio: accel: Add bmi085 and bmi090l
> bindings
> 
> This email is not from Hexagon's Office 365 instance. Please be careful while
> clicking links, opening attachments, or replying to this email.
> 
> 
> On Thu, May 26, 2022 at 01:33:59PM +0000, LI Qingwu wrote:
> > Adds the device-tree bindings for the Bosch
> > BMI085 and BMI090L IMU, the accelerometer part.
> >
> > Datasheet:
> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.bos
> ch-sensortec.com%2Fmedia%2Fboschsensortec%2Fdownloads%2Fdatasheets%
> 2Fbst-bmi085-ds001.pdf&amp;data=05%7C01%7C%7C6bb7d63d627c49b946c4
> 08da449fd9bf%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C6378977
> 51065729986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo
> iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdat
> a=K3PYyQAGsySCIjKuo1QRVm1HE0cuC3BVXbjuAwwhMjM%3D&amp;reserved=
> 0
> > Datasheet:
> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmedia.di
> gikey.com%2Fpdf%2FData%2520Sheets%2FBosch%2FBST-BMI090L-DS000-00.p
> df&amp;data=05%7C01%7C%7C6bb7d63d627c49b946c408da449fd9bf%7C1b1
> 6ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C637897751065729986%7CUnk
> nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h
> aWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=8GfqaDLkn5whi%2F
> bsEH9UATPNkJVgsy859sIifJGv%2BHg%3D&amp;reserved=0
> 
> blank line here. These aren't part of the tags.
Thank you, Rob, I did check, the most datasheets are part of the tags,
and few of them has a blank line, do you agree to keep it?
> 
> With that,
> 
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> 
> > Signed-off-by: LI Qingwu <Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > index 911a1ae9c83f..272eb48eef5a 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > @@ -17,7 +17,9 @@ description: |
> >  properties:
> >    compatible:
> >      enum:
> > +      - bosch,bmi085-accel
> >        - bosch,bmi088-accel
> > +      - bosch,bmi090l-accel
> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.25.1
> >
> >