>-----Original Message----- >From: Bart Van Assche [mailto:bvanassche@xxxxxxx] >Sent: Tuesday, May 31, 2022 9:18 AM >To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-arm- >kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- >scsi@xxxxxxxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx >Cc: devicetree@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; >krzysztof.kozlowski+dt@xxxxxxxxxx; vkoul@xxxxxxxxxx; avri.altman@xxxxxxx; >martin.petersen@xxxxxxxxxx; chanho61.park@xxxxxxxxxxx; >pankaj.dubey@xxxxxxxxxxx; linux-fsd@xxxxxxxxx; Bharat Uppal ><bharat.uppal@xxxxxxxxxxx> >Subject: Re: [PATCH 3/6] phy: samsung-ufs: add support for FSD ufs phy driver > >On 5/30/22 18:22, Alim Akhtar wrote: >> diff --git a/drivers/phy/samsung/phy-fsd-ufs.c b/drivers/phy/samsung/phy- >fsd-ufs.c >> new file mode 100644 >> index 000000000000..a03656006093 >> --- /dev/null >> +++ b/drivers/phy/samsung/phy-fsd-ufs.c >> @@ -0,0 +1,63 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * UFS PHY driver data for FSD SoC >> + * >> + * Copyright (C) 2022 Samsung Electronics Co., Ltd. >> + * >> + */ >> +#ifndef _PHY_FSD_UFS_H_ >> +#define _PHY_FSD_UFS_H_ > >Please do not use header file guards in a .c file. Noted. Thanks for point it out. > >Thanks, > >Bart.