On Wed, Jun 01, 2022 at 01:09:28PM +0200, Krzysztof Kozlowski wrote: > On 01/06/2022 13:06, Marty E. Plummer wrote: > > On Wed, Jun 01, 2022 at 01:00:38PM +0200, Krzysztof Kozlowski wrote: > >> On 01/06/2022 12:58, Marty E. Plummer wrote: > >>> On Tue, May 03, 2022 at 01:37:42PM +0200, Krzysztof Kozlowski wrote: > >>>> On 01/05/2022 19:34, Marty E. Plummer wrote: > >>>>> Add CRG driver for Hi3521A SoC. CRG (Clock and Reset Generator) module > >>>>> generates clock and reset signals used by other module blocks on SoC. > >>>>> > >>>>> Signed-off-by: Marty E. Plummer <hanetzer@xxxxxxxxxxxxx> > >>>>> --- > >>>>> drivers/clk/hisilicon/Kconfig | 8 ++ > >>>>> drivers/clk/hisilicon/Makefile | 1 + > >>>>> drivers/clk/hisilicon/crg-hi3521a.c | 141 ++++++++++++++++++++++ > >>>>> include/dt-bindings/clock/hi3521a-clock.h | 34 ++++++ > >>>> > >>>> Bindings go to separate patch. Your patchset is unmerge'able. > >>>> > >>> So, assuming I have the following patches: > >>> 1: +include/dt-bindings/clock/hi3521a-clock.h > >>> 2: +drivers/clk/hisilicon/crg-hi3521a.c > >>> 3: +Documentation/devicetree/bindings/whatever > >>> > >>> In what order should they be applied? > >> > >> Applied or sent? The maintainer will apply them in proper order, this is > >> bisectable. > >> > >> > > Either or. Whatever makes the workload easier is what I'm looking for. > > Sorry, you need to be more specific. Apply is not a job for you, for the > patch submitter. > > Then you miss here important piece - which is the first patch. DTS goes > always via separate branch (or even tree) from driver changes. That's > why bindings are always separate first patches. > So, add a 4: arch/arm/boot/dts/soc.dtsi and 5: arch/arm/boot/dts/board.dts to the above list, or should those be the same patch as well? > Best regards, > Krzysztof
