> Subject: Re: [PATCH 1/8] dt-bindings: interconnect: imx8m: Add bindings for > imx8mp noc > > On 01/06/2022 11:41, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@xxxxxxx> > > > > i.MX8MP features same NoC/NIC as i.MX8MM/N/Q, and use two compatible > > strings. > > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > > --- > > .../devicetree/bindings/interconnect/fsl,imx8m-noc.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml > > b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml > > index b8204ed22dd5..0923cd28d6c6 100644 > > --- > > a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml > > +++ b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yam > > +++ l > > @@ -26,16 +26,22 @@ properties: > > oneOf: > > - items: > > - enum: > > + - fsl,imx8mp-nic > > Please order the entries alphabetically, so 8mp goes after 8mm. > > > - fsl,imx8mn-nic > > - fsl,imx8mm-nic > > - fsl,imx8mq-nic > > - const: fsl,imx8m-nic > > - items: > > - enum: > > + - fsl,imx8mp-noc > > ditto > > > - fsl,imx8mn-noc > > - fsl,imx8mm-noc > > - fsl,imx8mq-noc > > - const: fsl,imx8m-noc > > + - items: > > + - const: fsl,imx8mp-noc > > + - const: fsl,imx8m-noc > > + - const: syscon > > This is a bit confusing - why this is also fallbacked as syscon? I thought to give some flexibility for drivers to access the address through syscon. But it could be removed, I could fix in V2. Thanks, Peng. > > > - const: fsl,imx8m-nic > > > > reg: > > > Best regards, > Krzysztof
