On 5/31/22 17:49, Rob Herring wrote: > On Tue, May 31, 2022 at 04:43:18PM -0400, Frank Rowand wrote: >> On 5/31/22 01:33, Qun-Wei Lin wrote: >>> The function check_node_name_chars_strict issues a false alarm when >>> compiling an overlay dts. >>> >>> /fragment@0/__overlay__: Character '_' not recommended in node name >>> >>> This workaround will fix it by skip checking for node named __overlay__. >> >> This is not a false alarm. >> >> Do not special case node name "__overlay__". This node name should never >> occur in a modern overlay source file. > > A dtbo -> dts pass will give warnings, so handling these nodes is > worthwhile. Though thinking a bit more about it, I think this one is off > by default, but W=2 turns it on. Yes, at least as of 5.18-rc1 the warning is only if '-W node_name_chars_strict', so a dtbo -> dts pass will not give the warning for node __overlay__ by default. -Frank > > Rob
