On Tue, May 31, 2022 at 10:01:01AM -0500, Rob Herring wrote: > On Fri, May 27, 2022 at 02:18:59AM +0300, Vladimir Oltean wrote: > > On Thu, May 26, 2022 at 05:04:50PM -0500, Rob Herring wrote: > > > On Thu, May 26, 2022 at 03:32:16AM +0300, Vladimir Oltean wrote: > > > > Also needed by nxp,sja1105.yaml and the following from brcm,b53.yaml: > > > > brcm,bcm5325 > > > > brcm,bcm5365 > > > > brcm,bcm5395 > > > > brcm,bcm5397 > > > > brcm,bcm5398 > > > > brcm,bcm53115 > > > > brcm,bcm53125 > > > > brcm,bcm53128 > > > > > > Okay. Looks like you missed bcm5389? > > > > I went to the end of drivers/net/dsa/b53/b53_spi.c and copied the > > compatible strings. "brcm,bcm5389" is marked in b53_mdio.c, so I would > > guess not. > > The datasheet I found says it is SPI interface, but I guess someone that > cares about this h/w can sort that out if needed. > > Rob If someone adds a new compatible string for a SPI controlled DSA switch, I will remember to remind him to update the dt-bindings doc as well.