On Mon, May 30, 2022 at 04:48:51PM +0800, Chen-Yu Tsai wrote:
> On Wed, May 25, 2022 at 11:58 PM Nícolas F. R. A. Prado
> <nfraprado@xxxxxxxxxxxxx> wrote:
> >
> > Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
> > PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
> > drive-strength-microamp instead of mediatek,drive-strength-adv.
> >
> > Since there aren't any users of mediatek,drive-strength-adv on mt8192
> > yet, remove this property and add drive-strength-microamp in its place,
> > which has a clearer meaning.
>
> Cool! Thanks for taking care of this~ I was looking at this and tried
> to make drive-strength and drive-strength-microamp mutually exclusive,
> but since they are optional, it didn't really work, and I put it on the
> back burner.
I didn't think of enforcing the properties to be mutually exclusive in the
dt-binding, but that is indeed a good idea. After a bit of head-scratching seems
like it is possible although unintuitive (by using 'required' inside the if
block). I'll send a v2 with this restriction added, and the same thing for patch
2, since bias-pull-up/down also shouldn't be used together with bias-disable.
Thanks,
Nícolas
>
>
> ChenYu
