> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Saturday, May 21, 2022 9:14 PM > To: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx>; > davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; > pabeni@xxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > harini.katakam@xxxxxxx; michal.simek@xxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; git@xxxxxxx > Subject: Re: [PATCH net-next] dt-bindings: net: xilinx: document xilinx emaclite > driver binding > > > On 20/05/2022 09:24, Radhey Shyam Pandey wrote: > > Add basic description for the xilinx emaclite driver DT bindings. > > > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx> > > --- > > Changes since RFC: > > - Add ethernet-controller yaml reference. > > - 4 space indent for DTS example. > > --- > > .../bindings/net/xlnx,emaclite.yaml | 63 +++++++++++++++++++ > > 1 file changed, 63 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > b/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > > new file mode 100644 > > index 000000000000..6105122ad583 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > > @@ -0,0 +1,63 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/xlnx,emaclite.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Xilinx Emaclite Ethernet controller > > + > > +allOf: > > + - $ref: ethernet-controller.yaml# > > This goes just before properties (so after maintainers). Ok . sure will fix in v2. > > > + > > +maintainers: > > + - Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx> > > + - Harini Katakam <harini.katakam@xxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - xlnx,opb-ethernetlite-1.01.a > > + - xlnx,opb-ethernetlite-1.01.b > > + - xlnx,xps-ethernetlite-1.00.a > > + - xlnx,xps-ethernetlite-2.00.a > > + - xlnx,xps-ethernetlite-2.01.a > > + - xlnx,xps-ethernetlite-3.00.a > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + phy-handle: true > > + > > + local-mac-address: true > > + > > + xlnx,tx-ping-pong: > > + type: boolean > > + description: hardware supports tx ping pong buffer. > > + > > + xlnx,rx-ping-pong: > > + type: boolean > > + description: hardware supports rx ping pong buffer. > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - phy-handle > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + axi_ethernetlite_1: ethernet@40e00000 { > > + compatible = "xlnx,xps-ethernetlite-3.00.a"; > > + interrupt-parent = <&axi_intc_1>; > > + interrupts = <1 0>; > > Is "0" an interrupt none type? If yes, then this should be rather a > define and a proper type, not none. I looked at axi intc driver and it seems second cell in unused here. For interrupt type level/edge , interrupt controller has separate binding "xlnx,kind-of-intr". So will remove the unused cell. + interrupts = <1>; > > > + local-mac-address = [00 0a 35 00 00 00]; > > Each device should get it's own MAC address, right? I understand you > leave it for bootloader, then just fill it with 0. The emaclite driver uses of_get_ethdev_address() to get mac from DT. i.e 'local-mac-address' if present in DT it will be read and this MAC address is programmed in the MAC core. So I think it's ok to have a user defined mac-address (instead of 0s) here in DT example? > > > + phy-handle = <&phy0>; > > + reg = <0x40e00000 0x10000>; > > Put the reg after compatible in DTS code. Ok, sure will fix it in v2. > > > + xlnx,rx-ping-pong; > > + xlnx,tx-ping-pong; > > + }; > > > Best regards, > Krzysztof
