On 27/05/2022 06:27, David Wang wrote: > The initial introduction of the jabil server with AST2600 BMC SoC. > > --- > > v4 > - Add document the new compatible. > - Delete redundant blank lines. > - Add a new line at end of file. Thanks for the changes but several fixes are still needed. If some of my comments are a bit unspecific, you can always ask for clarification. > > v3 > - Adjustment entries are ordered by name. > - Remove the bootargs property and modify the stdout-path property. > - Group multiple LED devices into a group. > - Modify the "gpio3_71" node name format. > - Delete unneeded blank line at the end. > > v2 > - Disable empty i2c bus. > - Remove gfx node because aspeed-g6.dtsi isn't supported. > - Modify the led format and add some properties. > - Fix wrong indentation. > - Add stdout property in chosen node. > - Rename temp to temperature-sensor in i2c bus 0. > > --- > > Signed-off-by: David Wang <David_Wang6097@xxxxxxxxx> > --- > .../bindings/arm/jabil/jabil-boards.yaml | 24 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > arch/arm/boot/dts/Makefile | 1 + > .../boot/dts/aspeed-bmc-jabil-rubypass.dts | 442 ++++++++++++++++++ > 4 files changed, 469 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/jabil/jabil-boards.yaml > create mode 100644 arch/arm/boot/dts/aspeed-bmc-jabil-rubypass.dts > > diff --git a/Documentation/devicetree/bindings/arm/jabil/jabil-boards.yaml b/Documentation/devicetree/bindings/arm/jabil/jabil-boards.yaml > new file mode 100644 > index 000000000000..dde7791aa8bc > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/jabil/jabil-boards.yaml > @@ -0,0 +1,24 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/jabil/jabil-boards.yaml# This should be aspeed. Let me send a send a base patch for all Aspeed boards. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Jabil Bmc and Aspeed SoC based boards > + > +maintainers: > + - David Wang <David_wang6097@xxxxxxxxx> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - description: Aspeed ast2600 bmc boards > + items: > + - const: jabil,rbp # eaglestream platform > + > +required: > + - compatible > + > +additionalProperties: true > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 01430973ecec..69738483c059 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -624,6 +624,8 @@ patternProperties: > description: Jiandangjing Technology Co., Ltd. > "^joz,.*": > description: JOZ BV > + "^jabil,.*": > + description: Jabil Design Service Branch (Sanchong) The list is ordered alphabetically, so jabil goes before. This should be also separate patch. > "^kam,.*": > description: Kamstrup A/S > "^karo,.*": Best regards, Krzysztof
