On 26/05/2022 23:05, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Thu, May 26, 2022 at 10:42 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>> Fix whitespace coding style: use single space instead of tabs or
>> multiple spaces around '=' sign in property assignment. No functional
>> changes (same DTB).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/draak.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/draak.dtsi
>> @@ -630,7 +630,7 @@ rsnd_for_ak4613: endpoint {
>> bitclock-master = <&rsnd_for_ak4613>;
>> frame-master = <&rsnd_for_ak4613>;
>> playback = <&ssi3>, <&src5>, <&dvc0>;
>> - capture = <&ssi4>, <&src6>, <&dvc1>;
>> + capture = <&ssi4>, <&src6>, <&dvc1>;
>
> I think the idea was to align the playback and capture properties,
> for easier comparison.
> Hence I'm a bit undecided if this needs to be fixed or not...
yeah, but then one should align "frame-master" to "bitclock-master" and
several other properties.
>
>> };
>> };
>> };
>
>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> @@ -206,12 +206,12 @@ pcm3168a: audio-codec@44 {
>> clocks = <&clksndsel>;
>> clock-names = "scki";
like here ^^^ - clocks with clock-names...
>>
>> - VDD1-supply = <&snd_3p3v>;
>> - VDD2-supply = <&snd_3p3v>;
>> - VCCAD1-supply = <&snd_vcc5v>;
>> - VCCAD2-supply = <&snd_vcc5v>;
>> - VCCDA1-supply = <&snd_vcc5v>;
>> - VCCDA2-supply = <&snd_vcc5v>;
>> + VDD1-supply = <&snd_3p3v>;
>> + VDD2-supply = <&snd_3p3v>;
>> + VCCAD1-supply = <&snd_vcc5v>;
>> + VCCAD2-supply = <&snd_vcc5v>;
>> + VCCDA1-supply = <&snd_vcc5v>;
>> + VCCDA2-supply = <&snd_vcc5v>;
>
> Same for the various supplies.
I don't think there is benefit to order few single entries, while entire
file does not follow that convention. It would be different for some
multiple-line entries, but that's not the case here.
Anyway that's only my opinion, so I am happy to trim the patch to the
last part (although then it is a bit churn :) ).
>
>>
>> ports {
>> #address-cells = <1>;
>> @@ -438,7 +438,7 @@ rsnd_for_pcm3168a_capture: endpoint {
>> bitclock-master;
>> frame-master;
>> dai-tdm-slot-num = <6>;
>> - capture = <&ssi4>;
>> + capture = <&ssi4>;
>
> Right, there's nothing to align here.
Best regards,
Krzysztof
