On Mon, 2022-05-23 at 11:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 23/05/22 10:40, Tim Chang ha scritto:
> > From: Jia-Wei Chang <jia-wei.chang@xxxxxxxxxxxx>
> >
> > MT8186 svs has a number of banks which used as optimization of opp
> > voltage table for corresponding dvfs drivers.
> > MT8186 svs big core uses 2-line high bank and low bank to optimize
> > the
> > voltage of opp table for higher and lower frequency respectively.
> >
> > Signed-off-by: Jia-Wei Chang <jia-wei.chang@xxxxxxxxxxxx>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> > drivers/soc/mediatek/mtk-svs.c | 351
> > ++++++++++++++++++++++++++++++++-
> > 1 file changed, 344 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/soc/mediatek/mtk-svs.c
> > b/drivers/soc/mediatek/mtk-svs.c
> > index 606a00a2e57d..656d0361ff7d 100644
> > --- a/drivers/soc/mediatek/mtk-svs.c
> > +++ b/drivers/soc/mediatek/mtk-svs.c
>
> ..snip..
>
> > @@ -2245,6 +2569,16 @@ static const struct svs_platform_data
> > svs_mt8192_platform_data = {
> > .bank_max = ARRAY_SIZE(svs_mt8192_banks),
> > };
> >
> > +static const struct svs_platform_data svs_mt8186_platform_data = {
> > + .name = "mt8186-svs",
> > + .banks = svs_mt8186_banks,
> > + .efuse_parsing = svs_mt8186_efuse_parsing,
> > + .probe = svs_mt8186_platform_probe,
> > + .irqflags = IRQF_TRIGGER_HIGH,
>
> I know I gave you my R-b tag earlier, but I've just noticed that:
> please remove
> irqflags, as this kind of flags are specified in devicetree and it is
> not
> necessary to specify them here.
>
> Thanks,
> Angelo
Hi Angelo,
Sure, I will remove it in the next version.
Thanks.
