On Tue, May 24, 2022 at 01:18:53AM +0300, Dmitry Baryshkov wrote: > > We're following the bindings and don't pick board-id or msm-id unless > > there's a particular reason for it - which typically is that the > > downstream bootloader requires it - we don't use the properties on the > > kernel side. > > Or unless we have another reason (like handling a single RB3+RB5 image). > I suspect PmOS might also like shipping a single image for some/all of > the supported devices. Or we might use that for the qcom-armv8a OE > machine. > On a larger scale the qcom,msm-id/board-id properties are not very useful for automatic DTB selection. This is simply because they are not unique when you look beyond just the Qualcomm reference boards. I know at least 3 totally different smartphones (from different vendors) where the bootloader picks "msm8916-mtp", even though they have little in common with Qualcomm's original MTP board. There are also vendors who made up their own broken numbering scheme, broken bootloaders that pick seemingly random DTBs or start modifying random properties etc etc. Perhaps it has improved on more recent devices but somehow I doubt it... This means that the qcom,msm-id/board-id properties are really just useful for making the bootloader happy, or if you have a number of devices in full control. It's not the consistently implemented standard that would actually be worth promoting for automatic DTB selection. > > > > > If the dtbTool support for the bindings is there, then there is no > > > breakage, because you had to use dtbTool before so you have to use now. > > > > > > > Among all the platforms I maintain, MSM8916 (db410c) is the only one > > where I use dtbTool - because it refuses to accept the concatenated > > dtb. > > It's strange, I have been using concatenated dtb with db410c for ages. > There is a patch in Linaro's LK fork for DB410c that selects the appended DTB even if the qcom,msm-id/board-id properties are missing: https://git.linaro.org/landing-teams/working/qualcomm/lk.git/commit/?id=3be1d459a546a24f2bf10b9551663a3e69a8214e If you don't have this commit or something equivalent, appended DTBs must have the qcom,msm-id/board-id properties for LK to accept them. Stephan
