Hi Chanho, On Tue, Sep 23, 2014 at 1:16 PM, Chanho Park <chanho61.park@xxxxxxxxxxx> wrote: > Hi, > >> -----Original Message----- >> From: linux-arm-kernel [mailto:linux-arm-kernel- >> bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Abhilash Kesavan >> Sent: Monday, September 22, 2014 1:47 PM >> To: linux-samsung-soc@xxxxxxxxxxxxxxx; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; >> catalin.marinas@xxxxxxx >> Cc: naveenkrishna.ch@xxxxxxxxx; kesavan.abhilash@xxxxxxxxx; >> tomasz.figa@xxxxxxxxx >> Subject: [PATCH v5 8/8] arm64: dts: add <dt-bindings/> symlink >> >> From: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> >> >> Add symlink to include/dt-bindings from arch/arm64/boot/dts/include/ to >> match the ones in ARM architectures so that preprocessed device >> tree files can include various useful constant definitions. >> >> See commit c58299aa8754 ("kbuild: create an "include chroot" for DT >> bindings") >> merged in v3.10-rc1 for details. >> >> CC: Catalin Marinas <catalin.marinas@xxxxxxx> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> >> Signed-off-by: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx> >> Reviewed-by: Thomas Abraham <thomas.ab@xxxxxxxxxxx> >> Tested-by: Thomas Abraham <thomas.ab@xxxxxxxxxxx> >> --- >> arch/arm64/boot/dts/include/dt-bindings | 1 + >> 1 file changed, 1 insertion(+) >> create mode 120000 arch/arm64/boot/dts/include/dt-bindings >> >> diff --git a/arch/arm64/boot/dts/include/dt-bindings >> b/arch/arm64/boot/dts/include/dt-bindings >> new file mode 120000 >> index 0000000..1e89bce >> --- /dev/null >> +++ b/arch/arm64/boot/dts/include/dt-bindings >> @@ -0,0 +1 @@ >> +../../../../../include/dt-bindings/ >> \ No newline at end of file > ^ > It generates incorrect symlink. Please remove last line like below: > > diff --git a/arch/arm64/boot/dts/include/dt-bindings > b/arch/arm64/boot/dts/include/dt-bindings > new file mode 120000 > index 0000000..499472b > --- /dev/null > +++ b/arch/arm64/boot/dts/include/dt-bindings > @@ -0,0 +1 @@ > +../../../../../include/dt-bindings/ I just re-checked this patch and it seems to be working fine. I did find a thread where patchwork appeared to be changing the patch causing issues [1]. Are you downloading this via patchwork ? [1] http://www.spinics.net/lists/linux-kbuild/msg08656.html Regards, Abhilash > -- > > Best Regards, > Chanho Park > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html