On 2022-05-23 18:30:38, Pavel Machek wrote: > Hi! > > > The Light Pulse Generator (LPG) is a PWM-block found in a wide range of > > PMICs from Qualcomm. It can operate on fixed parameters or based on a > > lookup-table, altering the duty cycle over time - which provides the > > means for e.g. hardware assisted transitions of LED brightness. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > I'd really like to see the patch fixing the pattern interface (or > disabling it). I don't want to push the tree to Linus with that bug. (I couldn't help but be confused for a minute by this being a reply to the original v1 patchset from March 2017 :) ) Does that mean there's still some time to review / pick up [1] (LPG enablement for PM660L)? And even more so for [2] (fixing the use of a software-pattern variable in the hardware-pattern code) which complements Bjorn's series but hasn't been looked at ever since last year. I wouldn't mind picking up this issue (discussed in the v14 series at [3]) and unblock you sending the tree to Linus without reverting, if Bjorn doesn't have the bandwidth for it currently. But I will need confirmation that patches sent in my name actually get looked at... Thanks! - Marijn [1]: https://lore.kernel.org/linux-leds/20220511190718.764445-1-marijn.suijten@xxxxxxxxxxxxxx/ [2]: https://lore.kernel.org/linux-leds/20210915080252.69147-1-marijn.suijten@xxxxxxxxxxxxxx/ [3]: https://lore.kernel.org/linux-leds/YnvhleAI5RW0ZvkV@ripper/T/#m6cb0d8df051bbcd3772d068640ccd784678ad47b