On 20/05/2022 13:52, Chanho Park wrote: > Adds samsung,boot-mode.h header file which contains boot mode > definitions for bootloader. As for now, there are only boot mode > definitions for Exynos Auto v9 SoC. > > Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx> Thank you for your patch. There is something to discuss/improve. > --- > include/dt-bindings/soc/samsung,boot-mode.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > create mode 100644 include/dt-bindings/soc/samsung,boot-mode.h > > diff --git a/include/dt-bindings/soc/samsung,boot-mode.h b/include/dt-bindings/soc/samsung,boot-mode.h > new file mode 100644 > index 000000000000..f1d03d96f45c > --- /dev/null > +++ b/include/dt-bindings/soc/samsung,boot-mode.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ Dual license: GPL-2.0-only OR BSD-2-Clause > + > +#ifndef __SAMSUNG_BOOT_MODE_H __DT_BINDINGS_SAMSUNG_BOOT_MODE_H > +#define __SAMSUNG_BOOT_MODE_H > + > +/* Boot mode definitions for Exynos Auto v9 SoC */ > + > +#define EXYNOSAUTOV9_BOOT_FASTBOOT (0xfa) > +#define EXYNOSAUTOV9_BOOT_BOOTLOADER (0xfc) > +#define EXYNOSAUTOV9_BOOT_RECOVERY (0xff) No need for (). > + > +#endif Best regards, Krzysztof