On 21/05/2022 00:19, Rob Herring wrote: > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> >> Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + >> 6 files changed, 6 insertions(+) > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > > Wasn't there some discussion about moving these to bindings/clocks/? > Maybe that was another one, it's all a blur... Yes, there was such idea although I am not sure if this is worth by itself - messes up with the git history. Best regards, Krzysztof