> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Wednesday, May 18, 2022 6:03 AM > To: Radhey Shyam Pandey <radheys@xxxxxxxxxx> > Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; > pabeni@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; Harini Katakam > <harinik@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; git <git@xxxxxxxxxx> > Subject: Re: [RFC net-next] dt-bindings: net: xilinx: document xilinx emaclite > driver binding > > On Thu, May 12, 2022 at 10:09:56PM +0530, Radhey Shyam Pandey wrote: > > Add basic description for the xilinx emaclite driver DT bindings. > > > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx> > > --- > > .../bindings/net/xlnx,emaclite.yaml | 60 +++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > > b/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > > new file mode 100644 > > index 000000000000..a3e2a0e89b24 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > > @@ -0,0 +1,60 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/xlnx,emaclite.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Xilinx Emaclite Ethernet controller > > + > > +maintainers: > > + - Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx> > > + - Harini Katakam <harini.katakam@xxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - xlnx,opb-ethernetlite-1.01.a > > + - xlnx,opb-ethernetlite-1.01.b > > + - xlnx,xps-ethernetlite-1.00.a > > + - xlnx,xps-ethernetlite-2.00.a > > + - xlnx,xps-ethernetlite-2.01.a > > + - xlnx,xps-ethernetlite-3.00.a > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + phy-handle: true > > + > > + local-mac-address: true > > + > > + xlnx,tx-ping-pong: > > + type: boolean > > + description: hardware supports tx ping pong buffer. > > + > > + xlnx,rx-ping-pong: > > + type: boolean > > + description: hardware supports rx ping pong buffer. > > Are these based on IP version or configuration of IP? These properties doesn't depend on IP version and are related to IP configuration. > > Rob