On Mon, 16 May 2022 18:06:38 +0200 Lorenzo Bianconi wrote: > /* PDMA RX Base Pointer Register */ > -#define MTK_PRX_BASE_PTR0 0x900 > +#define MTK_PRX_BASE_PTR0 (eth->soc->reg_map[MTK_PDMA_BASE] + 0x100) > #define MTK_PRX_BASE_PTR_CFG(x) (MTK_PRX_BASE_PTR0 + (x * 0x10)) Implicit macro arguments are really unpleasant for people doing tree-wide changes or otherwise unfamiliar with the driver. Nothing we can do to avoid this?