On Tue, 17 May 2022 at 09:26, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 15/05/2022 22:31, Robert Marko wrote: > > Convert the bindings of Qualcomm SPMI regulators to DT schema. > > > > Signed-off-by: Robert Marko <robimarko@xxxxxxxxx> > > --- > > I am aware that syscon alone is not really acceptable, its converted > > directly from the old text bindings. > > > > There is also the issue of some MSM8994, MSM8996 and APQ8096 devices using > > '#address-cells', '#size-cells', some even defining reg property for > > regulators. > > > > Any advice on how to solve these issues is appreciated. > > --- > > .../regulator/qcom,spmi-regulator.yaml | 176 ++++++++++++++++++ > > You miss here the actual conversion... where is the removal of old file? Hi, Oh yeah, sorry for forgetting this. Will fixup in v2. > > > 1 file changed, 176 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml > > > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml > > new file mode 100644 > > index 000000000000..f7da310f1845 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml > > @@ -0,0 +1,176 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/regulator/qcom,spmi-regulator.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm SPMI Regulators > > + > > +maintainers: > > + - Robert Marko <robert.marko@xxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - qcom,pm660-regulators > > + - qcom,pm660l-regulators > > + - qcom,pm8004-regulators > > + - qcom,pm8005-regulators > > + - qcom,pm8226-regulators > > + - qcom,pm8841-regulators > > + - qcom,pm8916-regulators > > + - qcom,pm8941-regulators > > + - qcom,pm8950-regulators > > + - qcom,pm8994-regulators > > + - qcom,pmi8994-regulators > > + - qcom,pms405-regulators > > + > > + qcom,saw-reg: > > + description: Reference to syscon node defining the SAW registers > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - qcom,pm8941-regulators > > + then: > > + properties: > > + interrupts: > > + items: > > + - description: Over-current protection interrupt for 5V S1 > > + - description: Over-current protection interrupt for 5V S2 > > + interrupt-names: > > + items: > > + - const: ocp-5vs1 > > + - const: ocp-5vs2 > > + > > +patternProperties: > > This goes just after "properties:" Will fixup in v2. Regards, Robert > > > + ".*-supply$": > > + description: Input supply phandle(s) for this node > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + > > Best regards, > Krzysztof