On Wed, May 04, 2022 at 12:46:31AM +0300, Serge Semin wrote: > There is no point in having the dw_pcie_region_type enumeration for almost > the same reasons as it was stated for dw_pcie_as_type. First of all it's > redundant since the driver already has a set of the macros declared which > describe the possible inbound and outbound iATU regions. Having an > addition abstraction just needlessly complicates the code. Secondly > checking the region type passed to the dw_pcie_disable_atu() method for > validity is pointless since the erroneous situation is just ignored in the > current method implementation. So to speak let's drop the redundant > dw_pcie_region_type enumeration replacing it with the direct iATU > direction macro usage. > > Since the dw_pcie_disable_atu() method now directly accepts the > in-/outbound iATU region direction instead of the abstract region type we > need to change the argument name and the arguments order. The later change > makes the function prototype looking more logical since the passed index > indicates an iATU window within the regions with the corresponding > direction. > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > > --- > > Changelog v2: > - Move this patch to being applied before the IB/OB iATU windows setup > simplification patch (@Rob). > --- > .../pci/controller/dwc/pcie-designware-ep.c | 4 +-- > .../pci/controller/dwc/pcie-designware-host.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.c | 28 +++++-------------- > drivers/pci/controller/dwc/pcie-designware.h | 13 ++------- > 4 files changed, 13 insertions(+), 34 deletions(-) Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
