On 2022-05-13 10:24:04, Krzysztof Kozlowski wrote: > On 12/05/2022 00:06, Marijn Suijten wrote: > > This PMIC is commonly used on boards with an SM6125 SoC and looks very > > similar in layout to the PM6150. > > > > Downstream declares more nodes to be available, but these have been > > omitted from this patch: the pwm/lpg block is unused on my reference > > device making it impossible to test/validate, and the spmi-clkdiv does > > not have a single device-tree binding using this driver yet, hence > > inclusion is better postponed until ie. audio which uses these clocks is > > brought up. > > > > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> > > Two reviews on first patch... :) Same story here, we review each-others patches in advance and it'd be annoying to have them re-send their approval through the mailing list; only for me/us to pick it up in a v2. > > + > > + pmic@1 { > > + compatible = "qcom,pm6125", "qcom,spmi-pmic"; > > + reg = <0x1 SPMI_USID>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > No children, so this should not be needed, I think. The size-cells or the entire node? There's a PWM/LPG block here according to downstream DT, but my device doesn't use it so I can't test that it is valid. I can add it anyway, presuming reviewers here have the ability to validate it for me with a reference manual. - Marijn