On 12/05/2022 18:04, Douglas Anderson wrote: > This copy-pastes compatibles from sc7180-based boards from the device > trees to the yaml file so that `make dtbs_check` will be happy. > > NOTES: > - I make no attempt to try to share an "item" for all sc7180 based > Chromebooks. Because of the revision matching scheme used by the > Chromebook bootloader, at times we need a different number of > revisions listed. > - Some of the odd entries in here (like google,homestar-rev23 or the > fact that "Google Lazor Limozeen without Touchscreen" changed from > sku5 to sku6) are not typos but simply reflect reality. > - Many revisions of boards here never actually went to consumers, but > they are still in use within various companies that were involved in > Chromebook development. Since Chromebooks are developed with an > "upstream first" methodology, having these revisions supported with > upstream Linux is important. Making it easy for Chromebooks to be > developed with an "upstream first" methodology is valuable to the > upstream community because it improves the quality of upstream and > gets Chromebooks supported with vanilla upstream faster. > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > > .../devicetree/bindings/arm/qcom.yaml | 180 ++++++++++++++++++ > 1 file changed, 180 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 5c06d1bfc046..399be67eb5d2 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -214,11 +214,191 @@ properties: > - qcom,ipq8074-hk10-c2 > - const: qcom,ipq8074 > > + # Qualcomm Technologies, Inc. SC7180 IDP > - items: > - enum: > - qcom,sc7180-idp > - const: qcom,sc7180 > > + # Google CoachZ (rev1 - 2) > + - items: > + - const: google,coachz-rev1 > + - const: google,coachz-rev2 The inverted pattern of old revision being compatible with the new one, is done on purpose? You claim here every rev1 is always compatible with rev2 ... I don't think we discussed such patterns in previous talk. I quickly went through it and there were only skuX moving around, not rev1 being newer then rev2. Best regards, Krzysztof
