Hi Rob, On 11 May 2022 16:04 Rob Herring wrote: > On Wed, May 04, 2022 at 10:44:55AM +0100, Phil Edworthy wrote: > > The RZ/V2M SoC has an additional clock to access the registers. The HW > > manual says this clock should not be touched as it is used by the > > "ISP Firmware". > > > > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > v4: > > - Removed "optional" from description of clock to access the registers > > v3: > > - New patch added > > --- > > .../bindings/serial/renesas,em-uart.yaml | 32 +++++++++++++++---- > > 1 file changed, 25 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/renesas,em- > uart.yaml b/Documentation/devicetree/bindings/serial/renesas,em-uart.yaml > > index 332c385618e1..40a03f255666 100644 > > --- a/Documentation/devicetree/bindings/serial/renesas,em-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/renesas,em-uart.yaml > > @@ -9,9 +9,6 @@ title: Renesas EMMA Mobile UART Interface > > maintainers: > > - Magnus Damm <magnus.damm@xxxxxxxxx> > > > > -allOf: > > - - $ref: serial.yaml# > > - > > properties: > > compatible: > > oneOf: > > @@ -29,11 +26,32 @@ properties: > > interrupts: > > maxItems: 1 > > > > - clocks: > > - maxItems: 1 > > +allOf: > > + - $ref: serial.yaml# > > > > - clock-names: > > - const: sclk > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: renesas,r9a09g011-uart > > + then: > > + properties: > > > + clocks: > > + items: > > + - description: UART functional clock > > + - description: Internal clock to access the registers > > + clock-names: > > + items: > > + - const: sclk > > + - const: pclk > > Better to put all this at the top level with 'minItems: 1' and then use > minItems/maxItems in the if/then schema to define which platforms have 1 > or 2 clocks. Thanks Rob, will do! Phil > > + else: > > + properties: > > + clocks: > > + items: > > + - description: UART functional clock > > + clock-names: > > + items: > > + - const: sclk > > > > required: > > - compatible > > -- > > 2.32.0 > > > >
