On 10/05/2022 14:49, Robert Marko wrote: Thank you for your patch. There is something to discuss/improve. > - > - - compatible: must contain "cznic,turris-mox" > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml > new file mode 100644 > index 000000000000..3f41ef2c6f3e > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/marvell/armada-37xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell Armada 37xx Platforms Device Tree Bindings > + > +maintainers: > + - Robert Marko <robert.marko@xxxxxxxxxx> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - description: Armada 3710 SoC > + items: > + - const: marvell,armada3710 This does not look correct. The SoC usually cannot be used by itself, it's always a part of some product, SoM, board. > + > + - description: Armada 3720 SoC > + items: > + - enum: > + - marvell,armada-3720-db > + - globalscale,espressobin > + - cznic,turris-mox > + - methode,udpu Order by name. > + - const: marvell,armada3720 > + - const: marvell,armada3710 > + > + - description: Globalscale Espressobin boards > + items: > + - enum: > + - globalscale,espressobin-emmc > + - globalscale,espressobin-ultra > + - globalscale,espressobin-v7 > + - const: globalscale,espressobin > + - const: marvell,armada3720 > + - const: marvell,armada3710 > + > + - description: Globalscale Espressobin V7 boards > + items: > + - enum: > + - globalscale,espressobin-v7-emmc > + - const: globalscale,espressobin-v7 > + - const: globalscale,espressobin > + - const: marvell,armada3720 > + - const: marvell,armada3710 > + > +additionalProperties: true Best regards, Krzysztof
