On Wed, May 11, 2022 at 07:10:03PM +0300, Vadym Kochan wrote: > Hi Chris, > > > arch/arm64/boot/dts/marvell/Makefile | 1 + > > .../boot/dts/marvell/armada-98dx2530.dtsi | 310 ++++++++++++++++++ > > arch/arm64/boot/dts/marvell/rd-ac5x.dts | 90 +++++ > > 3 files changed, 401 insertions(+) > > Marvell is going to start the upstreaming of AC5X boards support, we have also patches with similar .dts(i) files > but with different naming: > > ac5.dtsi > ac5_rd.dts > ac5_db.dts > ac5x_db.dts > > What do you think about to use these naming scheme ? Chris has done all the hard work, he gets to pick the naming. And get his files merged first. However, now that i come to look in arch/arm64/boot/dts/marvell, i think most of the current filenames proposed don't match the current names. armada-98dx2530.dtsi fits the current pattern. However, Chris's board files should probably be armada-98dx2530-rd.dts and the other files should be armada-98dx2530-db.dts armada-98dx2530-x-db.dts What does the x in x_db mean? Does that refer to the board or the SoC? Andrew
