On 10/05/2022 15:26, Allen-KH Cheng wrote: > Convert MediaTek eFuse devicetree binding to YAML. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx> > --- > .../bindings/nvmem/mediatek,efuse.yaml | 57 +++++++++++++++++++ > .../devicetree/bindings/nvmem/mtk-efuse.txt | 43 -------------- > 2 files changed, 57 insertions(+), 43 deletions(-) > create mode 100644 Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > delete mode 100644 Documentation/devicetree/bindings/nvmem/mtk-efuse.txt > > diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > new file mode 100644 > index 000000000000..529f5888d93f > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/nvmem/mediatek,efuse.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek eFuse > + > +maintainers: > + - Lala Lin <lala.lin@xxxxxxxxxxxx> > + - Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx> > + > +allOf: > + - $ref: "nvmem.yaml#" > + > +properties: > + compatible: > + oneOf: > + - enum: > + - mediatek,mt8173-efuse > + - mediatek,efuse > + description: > + Only mt8173 SoC-specific compatible with generic fallback should be > + used I don't see changes here after our v2 discussion. In the past several comments were not implemented in new versions (filename, title). So this is one more case where you receive a comment and send a next version without implementing it. Can you please focus on the received comments and not loose pieces of them? https://lore.kernel.org/all/0169c4ac-fdce-29b7-553a-14dc7df532d1@xxxxxxxxxx/ Best regards, Krzysztof