On Fri, Sep 5, 2014 at 7:53 AM, Weike Chen <alvin.chen@xxxxxxxxx> wrote:
> This patch enables suspend and resume mode for the power management, and
> it is based on Josef Ahmad's previous work.
>
> Reviewed-by: Hock Leong Kweh <hock.leong.kweh@xxxxxxxxx>
> Reviewed-by: Shevchenko, Andriy <andriy.shevchenko@xxxxxxxxx>
> Signed-off-by: Weike Chen <alvin.chen@xxxxxxxxx>
(...)
> +/* Store GPIO context across system-wide suspend/resume transitions */
> +static struct dwapb_context {
> + u32 data[DWAPB_MAX_PORTS];
> + u32 dir[DWAPB_MAX_PORTS];
> + u32 ext[DWAPB_MAX_PORTS];
> + u32 int_en;
> + u32 int_mask;
> + u32 int_type;
> + u32 int_pol;
> + u32 int_deb;
> +} dwapb_context;
NAK, this should STILL be part of the device state container. Not
a local variable.
I've said this before. Please fix this, thanks.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
