Am 7. Mai 2022 22:01:22 MESZ schrieb Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>: >On 07/05/2022 19:04, Frank Wunderlich wrote: >> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >> >> Make reset optional as driver already supports it, > >I do not see the connection between hardware needing or not needing a >reset GPIO and a driver supporting it or not... What does it mean? My board has a shared gpio-reset between gmac and switch, so both will resetted if it is asserted. Currently it is set to the gmac and is aquired exclusive. Adding it to switch results in 2 problems: - due to exclusive and already mapped to gmac, switch driver exits as it cannot get the reset-gpio again. - if i drop the reset from gmac and add to switch, it resets the gmac and this takes too long for switch to get up. Of course i can increase the wait time after reset,but dropping reset here was the easier way. Using reset only on gmac side brings the switch up. >> allow port 5 as >> cpu-port > >How do you allow it here? Argh, seems i accidentally removed this part and have not recognized while checking :( It should only change description of reg for ports to: "Port address described must be 5 or 6 for CPU port and from 0 to 5 for user ports." regards Frank
