Quoting Satya Priya (2022-05-05 02:25:36) > diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c > index 40a67f0..25e8d0b 100644 > --- a/drivers/mfd/qcom-pm8008.c > +++ b/drivers/mfd/qcom-pm8008.c > @@ -150,6 +151,11 @@ static struct regmap_config qcom_mfd_regmap_cfg = { > .max_register = 0xFFFF, > }; > > +struct regmap *pm8008_get_regmap(struct pm8008_data *chip) can chip be const? > +{ > + return chip->regulators_regmap; > +} EXPORT_SYMBOL_GPL please. And the include is needed to avoid sparse warning. > + > static int pm8008_init(struct regmap *regmap) > { > int rc;