On 06/05/2022 05:23, Qin Jian wrote: > Add documentation to describe Sunplus SP7021 clock driver bindings. > > Signed-off-by: Qin Jian <qinjian@xxxxxxxxxxx> > --- > fix the comments from Krzysztof & Rob. > --- > .../bindings/clock/sunplus,sp7021-clkc.yaml | 51 +++++++++++ > MAINTAINERS | 2 + > include/dt-bindings/clock/sp-sp7021.h | 88 +++++++++++++++++++ > 3 files changed, 141 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml > create mode 100644 include/dt-bindings/clock/sp-sp7021.h > > diff --git a/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml > new file mode 100644 > index 000000000..859b2cca5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. 2021 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/sunplus,sp7021-clkc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sunplus SP7021 SoC Clock Controller Binding > + > +maintainers: > + - Qin Jian <qinjian@xxxxxxxxxxx> > + > +properties: > + compatible: > + const: sunplus,sp7021-clkc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + "#clock-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - "#clock-cells" > + > +additionalProperties: false > + > +examples: > + - | > + No need for blank line. > + extclk: osc0 { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <27000000>; > + clock-output-names = "extclk"; > + }; > + > + clkc: clock-controller@9c000000 { > + compatible = "sunplus,sp7021-clkc"; > + reg = <0x9c000000 0x280>; > + clocks = <&extclk>; > + #clock-cells = <1>; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 26066f199..5d8b420d0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2744,8 +2744,10 @@ L: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for mon-subscribers) > S: Maintained > W: https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview > F: Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml > +F: Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml > F: Documentation/devicetree/bindings/reset/sunplus,reset.yaml > F: drivers/reset/reset-sunplus.c > +F: include/dt-bindings/clock/sp-sp7021.h > F: include/dt-bindings/reset/sp-sp7021.h > > ARM/Synaptics SoC support > diff --git a/include/dt-bindings/clock/sp-sp7021.h b/include/dt-bindings/clock/sp-sp7021.h Please match the filename to the bindings, so vendor,device ("sunplus,sp7021-clkc.h") Best regards, Krzysztof
