Re: [PATCH v3 6/6] ARM: configs: at91: sama7_defconfig: add MCHP PDMC and DMIC drivers

Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx> · Thu, 5 May 2022 15:58:34 +0200

On 07/03/2022 at 13:22, Codrin Ciubotariu wrote:
Enable drivers needed for Microchip's PDMC and PDM microphones.

Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>
---

Changes in v2,v3:
  - none;

  arch/arm/configs/sama7_defconfig | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/sama7_defconfig b/arch/arm/configs/sama7_defconfig
index 0368068e04d9..bc29badab890 100644
--- a/arch/arm/configs/sama7_defconfig
+++ b/arch/arm/configs/sama7_defconfig
@@ -138,6 +138,8 @@ CONFIG_SND_SOC_MIKROE_PROTO=m
  CONFIG_SND_MCHP_SOC_I2S_MCC=y
  CONFIG_SND_MCHP_SOC_SPDIFTX=y
  CONFIG_SND_MCHP_SOC_SPDIFRX=y
+CONFIG_SND_MCHP_SOC_PDMC=y
+CONFIG_SND_SOC_DMIC=y

I'm fine with that, but I see that some Kconfig entries "select" this 
SND_SOC_DMIC directly (amd, intel, mediatek, stm).
If it's absolutely needed for PDMC to work, what about doing the same as 
it would prevent some broken configurations?

Regards,
  Nicolas

  CONFIG_SND_SOC_PCM5102A=y
  CONFIG_SND_SOC_SPDIF=y
  CONFIG_SND_SIMPLE_CARD=y


--
Nicolas Ferre






