On Thu, May 05, 2022 at 01:25:31AM +0200, Andrew Lunn wrote: > On Tue, May 03, 2022 at 05:16:25PM +0200, Ansuel Smith wrote: > > Drop NETDEV_LED_MODE_LINKUP from mode list and convert to a simple bool > > that will be true or false based on the carrier link. No functional > > change intended. > > What is missing from the commit message is an explanation why? > > Andrew Will add the reason. Just in case it doesn't make sense... The reason is that putting a state in the mode bitmap doesn't look correct. It's ""acceptable"" if we have only 3 state (rx, tx and link). It become problematic when we start to have 7 modes and a link up state should be handled differently. Does it make sense? -- Ansuel
