Hi Ajay, On Wednesday 17 September 2014 15:43:04 Ajay kumar wrote: > Hi Laurent, > > Please find the latest series here: > http://www.spinics.net/lists/dri-devel/msg66740.html Thank you. My comment was meant to be general though, not just for your patch series. > On Wed, Sep 17, 2014 at 3:23 PM, Laurent Pinchart wrote: > > On Wednesday 30 July 2014 11:40:54 Thierry Reding wrote: [snip] > >> One other thing: how does the bridge know which mode to drive? I suspect > >> that it can drive more than one mode? Can it freely be configured or > >> does it have a predefined set of modes? If the latter, then according to > >> what you said above there needs to be a way to configure the bridge (via > >> DT?) so that it reports the mode matching the panel. I wonder if that > >> should be handled completely in code, so that for example a bridge has a > >> panel attached it can use the panel's .get_modes() and select a matching > >> mode among the set that it supports. > > > > Yes, pretty please :-) I don't think it would be a good idea to duplicate > > mode information in the bridge DT node, as that's not a property of the > > bridge. Querying the mode at runtime is in my opinion a much better > > option, and would also allow switching between different modes at runtime > > when that makes sense. > > > > Now, I'm not sure whether it should be the bridge driver querying the > > panel driver directly, or the display controller driver doing it and then > > configuring the bridge accordingly. The latter seems more generic to me > > and doesn't rely on the assumption that the bridge output will always be > > directly connected to a panel. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html