On Wed, Sep 17, 2014 at 02:12:28AM +0100, Kever Yang wrote: > Hi Mark, > > Thanks for your comment. > On 09/17/2014 02:54 AM, Mark Rutland wrote: > > On Tue, Sep 16, 2014 at 11:44:28AM +0100, Kever Yang wrote: > >> This add documentation for rk3288 smp dt binding > >> > >> Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx> > >> --- > >> > >> Changes in v2: > >> - add documentation > >> > >> Documentation/devicetree/bindings/arm/cpus.txt | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt > >> index 298e2f6..4b46233 100644 > >> --- a/Documentation/devicetree/bindings/arm/cpus.txt > >> +++ b/Documentation/devicetree/bindings/arm/cpus.txt > >> @@ -195,6 +195,7 @@ nodes to be present and contain the properties described below. > >> "qcom,kpss-acc-v1" > >> "qcom,kpss-acc-v2" > >> "rockchip,rk3066-smp" > >> + "rockchip,rk3288-smp" > > How do these differ? > rk3066 and rk3288 smp bring up code is quite different, so I need a new > node "rockchip,rk3288-smp" > other than "rockchip,rk3066-smp". The code being different is a Linux detail. What is different in the HW that necessitates the code being different? > > What does "rockchip,rk3288-smp" mean exactly? > The driver who using this node is in 2/3 of this patchset, it goes to > linux-arm-kernel list and linux-rockchip > list, I'm not sure if you have get that, maybe I need a RESEND? Documentaiton and drivers are different things. A binding is a contract, and for that contract to be meaningful it needs to be described. > > Presumably other nodes / properties are required? > Base on linux-next, I think only "rockchip,rk3288-smp" is new node to my > driver. But presumably there are other resources that you require (e.g. a system controller, perhaps a specific portion of sram). I can't just put "rockchip,rk3288-smp" into an otherwise empty DT and get SMP support, I would assume. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
