On 03/05/2022 12:55, Kavyasree Kotagiri wrote: > This adds DT bindings documentation for lan966 flexcom > mux controller. > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx> > --- > .../mux/microchip,lan966-flx-mux.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml > > diff --git a/Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml b/Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml > new file mode 100644 > index 000000000000..8b20f531781a > --- /dev/null > +++ b/Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mux/microchip,lan966-flx-mux.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: microchip Lan966 Flexcom multiplexer bindings > + > +maintainers: > + - Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx> > + > +description: |+ > + The Microchip Lan966 have 5 Flexcoms. Each flexcom has 2 chip-selects > + when operating in USART and SPI modes. > + Each chip select of each flexcom can be mapped to 21 flexcom shared pins. > + Define register offset and pin number to map a flexcom chip-select > + to flexcom shared pin. > + > +properties: Usually you need allOf referencing mux-controller. > + compatible: > + enum: > + - microchip,lan966-flx-mux > + > + reg: > + maxItems: 1 > + > + '#mux-control-cells': > + const: 1 > + > + mux-offset-pin: > + description: an array of register offset and flexcom shared pin(0-20). > + > +required: > + - compatible > + - '#mux-control-cells' > + - mux-offset-pin and reg? > + > +additionalProperties: false > + > +examples: > + - | > + mux: mux-controller@e2004168 { > + compatible = "microchip,lan966-flx-mux"; > + reg = <0xe2004168 0x8>; > + #mux-control-cells = <1>; > + mux-offset-pin = > + <0x18 9>; /* 0: flx3 cs0 offset, pin-9 */ You could put it in one line, I think. > + }; > + > + flx3 { > + atmel,flexcom-mode = <2>; > + mux-controls = <&mux 0>; > + mux-control-names = "cs0"; > + }; No need for example for typical consumers. They are obvious and already documented. > +... Best regards, Krzysztof