Re: [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 26, 2022 at 8:00 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> v2:
>  - Fix the example in samsung,s3c2410-i2c.yaml
>
>  Documentation/devicetree/bindings/eeprom/at24.yaml            | 4 +++-

For at24 part:

Acked-by: Bartosz Golaszewski <brgl@xxxxxxxx>

>  .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml          | 2 +-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 6b61a8cf6137..d14e0accbda8 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -120,7 +120,9 @@ properties:
>            - const: giantec,gt24c32a
>            - const: atmel,24c32
>        - items:
> -          - const: renesas,r1ex24128
> +          - enum:
> +              - renesas,r1ex24128
> +              - samsung,s524ad0xd1
>            - const: atmel,24c128
>
>    label:
> diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> index c26230518957..3d5782deb97d 100644
> --- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> @@ -123,7 +123,7 @@ examples:
>          samsung,i2c-slave-addr = <0x66>;
>
>          eeprom@50 {
> -            compatible = "samsung,s524ad0xd1";
> +            compatible = "samsung,s524ad0xd1", "atmel,24c128";
>              reg = <0x50>;
>          };
>      };
> --
> 2.34.1
>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux